[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

davidstone updated this revision to Diff 333135. davidstone added a comment. [clang] Handle 128-bits IntegerLiterals in StmtPrinter This fixes PR35677: "__int128_t or __uint128_t as non-type template parameter causes crash when considering invalid constructor". Repository: rG LLVM Github Mono

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

riccibruno added a comment. In addition to Aaron's suggestion, can you also change the diff's title to something a little bit more informative. Suggestion: "[clang] Handle 128-bits IntegerLiterals in StmtPrinter", and say in the description that this addresses PR35677. Repository: rG LLVM G

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

aaron.ballman added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; davidstone wrote: > aaron.ballman wrote: > > riccibruno wrote: > > > riccibruno wrote: > > > > davidstone wrote: > >

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

davidstone marked an inline comment as done. davidstone added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; aaron.ballman wrote: > riccibruno wrote: > > riccibruno wrote: > > > davids

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

aaron.ballman added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; riccibruno wrote: > riccibruno wrote: > > davidstone wrote: > > > riccibruno wrote: > > > > `i128` and `Ui128` are no

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

riccibruno added a subscriber: majnemer. riccibruno added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; riccibruno wrote: > davidstone wrote: > > riccibruno wrote: > > > `i128` and `U

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

riccibruno added a subscriber: aaron.ballman. riccibruno added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; davidstone wrote: > riccibruno wrote: > > `i128` and `Ui128` are not valid

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

davidstone marked an inline comment as done. davidstone added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; riccibruno wrote: > `i128` and `Ui128` are not valid integer literal suffix

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

riccibruno added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; `i128` and `Ui128` are not valid integer literal suffix. The output of `StmtPrinter` is intended to be valid C++. Unfor

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

davidstone created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82880 Files: clang/lib/AST/StmtPrinter.cpp clang/test/AST/ast-print-int128.cpp Index: clang/test/AST/ast-print-int128.cpp