[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

2020-07-09 Thread Daniel Grumberg via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG50f24331fd91: Add diagnostic option backing field for -fansi-escape-codes (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82874/new/ https

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

2020-07-02 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 275187. dang added a comment. Make the tablegen description of the new option more consistent with other flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82874/new/ https://reviews.llvm.org/D82874 Files: c

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

2020-06-30 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 274541. dang added a comment. Move the call to `UseANSIEscapeCodes` to `CreateFromArgs` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82874/new/ https://reviews.llvm.org/D82874 Files: clang/include/clang/Basic/

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

2020-06-30 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm with the fix I mentioned. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3629 #undef MERGE_ASSIGN_VALUE + llvm::sys::Process::UseANSIEscapeCodes(Diagnosti

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

2020-06-30 Thread Daniel Grumberg via Phabricator via cfe-commits
dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. dang edited the summary of this revision. Keep track of -fansi-escape-codes in DiagnosticOptions and move the option to the new option parsing system. D