This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rGed398c3ca404: [NFC] Extract unifyTargetFeatures (authored by
yaxunl).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:93
+StringRef Name = Features[I];
+assert(Name[0] == '-' || Name[0] == '+');
+LastOpt[Name.drop_front(1)] = I
yaxunl marked 3 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:93
+StringRef Name = Features[I];
+assert(Name[0] == '-' || Name[0] == '+');
+LastOpt[Name.drop_front(1)] = I;
tra wrote:
> y
tra marked an inline comment as done.
tra added inline comments.
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:93
+StringRef Name = Features[I];
+assert(Name[0] == '-' || Name[0] == '+');
+LastOpt[Name.drop_front(1)] = I;
yaxunl wrote:
> tra
yaxunl updated this revision to Diff 273473.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
return the unified features.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82579/new/
https://reviews.llvm.org/D82579
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clang/lib
yaxunl marked 4 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:93
+StringRef Name = Features[I];
+assert(Name[0] == '-' || Name[0] == '+');
+LastOpt[Name.drop_front(1)] = I;
tra wrote:
> I
tra added inline comments.
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:93
+StringRef Name = Features[I];
+assert(Name[0] == '-' || Name[0] == '+');
+LastOpt[Name.drop_front(1)] = I;
I don't think assert should be used for something that may
yaxunl created this revision.
yaxunl added a reviewer: tra.
yaxunl added a child revision: D82506: [HIP] Add missing options for lto.
extract unifyTargetFeatures to be used by lld.
https://reviews.llvm.org/D82579
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clang/lib/Driver/ToolChains/Commo
