[PATCH] D82574: Merge TableGen files used for clang options

dang added a comment. Sorry again, removed the offending options in a2cffb11e287 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82574/new/ https://reviews.llvm.org/D82574

[PATCH] D82574: Merge TableGen files used for clang options

vdmitrie added inline comments. Comment at: clang/include/clang/Driver/Options.td:3668 + HelpText<"Do not emit code that uses the red zone.">; +def dwarf_column_info : Flag<["-"], "dwarf-column-info">, + HelpText<"Turn on column location information.">; This op

[PATCH] D82574: Merge TableGen files used for clang options

dang added a comment. In D82574#2144140 , @jeroen.dobbelaere wrote: > I think that 'clang/include/clang/Driver/CC1Options.td' should also be > removed ? Yes must have missed it when rebasing. Done now in 3607aacc5981

[PATCH] D82574: Merge TableGen files used for clang options

jeroen.dobbelaere added a comment. I think that 'clang/include/clang/Driver/CC1Options.td' should also be removed ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82574/new/ https://reviews.llvm.org/D82574

[PATCH] D82574: Merge TableGen files used for clang options

dang marked 2 inline comments as done. dang added inline comments. Comment at: clang/include/clang/Driver/Options.td:3455 + HelpText<"Specify target triple (e.g. i686-apple-darwin9)">, + MarshallingInfoString<"TargetOpts->Triple", "llvm::sys::getDefaultTargetTriple()", "std::s

[PATCH] D82574: Merge TableGen files used for clang options

dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/Driver/Options.td:3455 + HelpText<"Specify target triple (e.g. i686-apple-darwin9)">, + MarshallingInfoString<"TargetOpts->Triple", "llvm::sys::getDefaultTargetTriple()", "std::s

[PATCH] D82574: Merge TableGen files used for clang options

herhut added a comment. Could you add the normalization back? This is in line with the comment to make sure the old and new files align. Comment at: clang/include/clang/Driver/Options.td:3455 + HelpText<"Specify target triple (e.g. i686-apple-darwin9)">, + MarshallingInfoStr

[PATCH] D82574: Merge TableGen files used for clang options

dang added a comment. Yes I committed this a while ago, I duplicated all the functionality in Options.td. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82574/new/ https://reviews.llvm.org/D82574 ___ c

[PATCH] D82574: Merge TableGen files used for clang options

dmgreen added a comment. Hello Did you mean to remove CC1Options.td too? Otherwise it does not appear to be used any more or this has duplicated the contents. Also can you make sure the new content of Options.td reflects the latest version of CC1Options.td, and that no extra changes have been

[PATCH] D82574: Merge TableGen files used for clang options

This revision was automatically updated to reflect the committed changes. Closed by commit rGfccd29dddee9: Merge TableGen files used for clang options (authored by dang). Changed prior to commit: https://reviews.llvm.org/D82574?vs=273407&id=276775#toc Repository: rG LLVM Github Monorepo CHA

[PATCH] D82574: Merge TableGen files used for clang options

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. We can look at splitting it up again once we know what the dependencies are. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82574/new