[PATCH] D82562: Implement AVX ABI Warning/error

jajadude added a comment. Herald added subscribers: StephenFan, pengfei. Herald added a project: All. if (Callee->getReturnType()->isVectorType() && CGM.getContext().getTypeSize(Callee->getReturnType()) > 128) { } I think this condition will make features like ext_vector_type to be warnings

[PATCH] D82562: Implement AVX ABI Warning/error

erichkeane added a comment. In D82562#2191512 , @dmajor wrote: > @erichkeane, could you help me understand what is the action item of these > warnings? > > In Firefox we don't require AVX so our compilations generally don't enable > the feature. (A very

[PATCH] D82562: Implement AVX ABI Warning/error

dmajor added a comment. @erichkeane, could you help me understand what is the action item of these warnings? In Firefox we don't require AVX so our compilations generally don't enable the feature. (A very small number of files do come with AVX versions, mostly in imported media codecs, but the

[PATCH] D82562: Implement AVX ABI Warning/error

This revision was automatically updated to reflect the committed changes. erichkeane marked an inline comment as done. Closed by commit rG2831a317b689: Implement AVX ABI Warning/error (authored by erichkeane). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D825

[PATCH] D82562: Implement AVX ABI Warning/error

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM other than that one minor. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2515 + SourceLocation CallLoc, + ll

[PATCH] D82562: Implement AVX ABI Warning/error

erichkeane updated this revision to Diff 274450. erichkeane marked an inline comment as done. erichkeane added a comment. As @craig.topper suggested, extract the four lookups into 2 bool instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82562/new/ https://reviews.llvm.org/D82562 F

[PATCH] D82562: Implement AVX ABI Warning/error

craig.topper added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2497 + bool IsArgument) { + if (!CallerMap.lookup(Feature) && !CalleeMap.lookup(Feature)) +return Diag.Report(CallLoc, diag::warn_avx_calling_convention)

[PATCH] D82562: Implement AVX ABI Warning/error

erichkeane updated this revision to Diff 274106. erichkeane marked 6 inline comments as done. erichkeane added a comment. Do all feedback as @craig.topper recommended. Instead of using 'find', I was able to use 'lookup' on the map, which seemed to be exactly what I want. CHANGES SINCE LAST ACT

[PATCH] D82562: Implement AVX ABI Warning/error

craig.topper added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:246 + "enabled changes the ABI">, + InGroup>; +def err_avx_calling_convention : Error; Should this be -Wpsabi to match gcc? I think that's what

[PATCH] D82562: Implement AVX ABI Warning/error

erichkeane created this revision. erichkeane added reviewers: craig.topper, echristo. The x86-64 "avx" feature changes how >128 bit vector types are passed, instead of being passed in separate 128 bit registers, they can be passed in 256 bit registers. "avx512f" does the same thing, except it swi