This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rGe9fb1506b83d: [clangd] Config: Fragments and parsing from
YAML (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D82386?vs=273254&id=
sammccall marked 9 inline comments as done.
sammccall added a comment.
Thanks for the careful review!
Comment at: clang-tools-extra/clangd/ConfigFragment.h:73
+/// Only valid if SourceManager is set.
+llvm::SMLoc Location;
+ };
kadircet wrote:
> sammcc
kadircet marked 5 inline comments as done.
kadircet added a comment.
LGTM with couple of nits.
Regarding clang-format, I was mostly confused by `template class
Located {` being on a single line, but apparently that's the style :D
Comment at: clang-tools-extra/clangd/ConfigFr
sammccall added a comment.
Thanks!
> Apart from the comments(IIRC which are mostly minor), it felt like there were
> a few lines that aren't clang-format'd. Please make sure to run clang-format
> on the files at some point.
git-clang-format thinks it's clean, so please point out any examples y
sammccall updated this revision to Diff 273254.
sammccall marked 38 inline comments as done.
sammccall added a comment.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82386/new/
https://reviews.llvm.org/D82386
Files:
clang
kadircet added a comment.
Thanks! Looks great, I've finally managed to finish all my iterations :D
Apart from the comments(IIRC which are mostly minor), it felt like there were a
few lines that aren't clang-format'd. Please make sure to run clang-format on
the files at some point.
==
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ConfigYAML.cpp:29
+ llvm::SourceMgr &SM;
+ llvm::SmallString<256> Buf;
+
a comment for this buf, especially the reason why it's a member rather than a
function-local when needed. (I suppose t
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ConfigFragment.h:9
+//
+// Various clangd features have configurable behaviour (or can be disabled).
+// The configuration system allows users to control this:
i think this paragraph belongs to
sammccall created this revision.
sammccall added reviewers: kadircet, adamcz.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov, mgorny.
Herald added a project: clang.
This is a piece from the design in https://tinyurl.com/clangd-config
https://reviews.ll
