This revision was automatically updated to reflect the committed changes.
Closed by commit rGbd46a56474d3: [OpenCL] Reject block arguments (authored by
svenvh).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82313/new/
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82313/new/
https://reviews.llvm.org/D82313
___
cfe-commits mailing lis
svenvh updated this revision to Diff 273253.
svenvh added a comment.
Add test case with a block as a parameter of another block.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82313/new/
https://reviews.llvm.org/D82313
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/li
Anastasia added inline comments.
Comment at: clang/test/SemaOpenCL/invalid-block.cl:31
typedef int (^bl_t)(void);
-bl_t f3(bl_t bl); // expected-error{{declaring function return value of type
'bl_t' (aka 'int (__generic ^const)(void)') is not allowed}}
+bl_t f3a(int); // ex
svenvh created this revision.
svenvh added a reviewer: Anastasia.
Herald added a subscriber: yaxunl.
OpenCL 2.0 does not allow block arguments, primarily because it is
difficult to support function pointers on the various architectures
that OpenCL targets. Clang was still accepting them.
Rename
