[PATCH] D81691: [clangd] Set CWD in semaCodeComplete

2020-06-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81691/new/ https://reviews.llvm.org/D81691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D81691: [clangd] Set CWD in semaCodeComplete

2020-06-11 Thread Jan Korous via Phabricator via cfe-commits
jkorous added a comment. A slightly tangential thing - we recently got an internal bugreport about clangd handling combination of working directory and relative paths for `-fmodules-cache-path` combination in compile_command.json incorrectly. I tried some quick hacks but failed - it seems that u

[PATCH] D81691: [clangd] Set CWD in semaCodeComplete

2020-06-11 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf44d2424f8d7: [clangd] Set CWD in semaCodeComplete (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D81691: [clangd] Set CWD in semaCodeComplete

2020-06-11 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81691 Files: clang-tools-extra/clangd/CodeComplete.cpp Index: clang-too