[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bdcd95bf20f: [SYCL][OpenMP] Implement thread-local storage restriction (authored by Fznamznon, committed by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

Fznamznon updated this revision to Diff 271327. Fznamznon edited the summary of this revision. Fznamznon added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81641/new/ https://reviews.llvm.org/D81641 Files: clang/lib/Sema/Sem

[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

bader added a comment. In D81641#2097433 , @Fznamznon wrote: > Seems that `test/OpenMP/nvptx_target_codegen.cpp` is completely not > formatted. If I apply suggestion from pre-merge checks, this will look like a > big unrelated to this patch change and it

[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

Fznamznon added a comment. Seems that `test/OpenMP/nvptx_target_codegen.cpp` is completely not formatted. If I apply suggestion from pre-merge checks, this will look like a big unrelated to this patch change and it will contradict with the whole file style. Repository: rG LLVM Github Monorep

[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

jdoerfert accepted this revision. jdoerfert added a comment. In D81641#2096114 , @Fznamznon wrote: > In D81641#2088446 , @jdoerfert wrote: > > > OpenMP has the same restriction (no surprise I guess). Thanks for the

[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

Fznamznon added a comment. In D81641#2088446 , @jdoerfert wrote: > OpenMP has the same restriction (no surprise I guess). Thanks for the ping! > > I think we do not emit diagnosis right now: https://godbolt.org/z/srDkXZ > I think we also should diagnose t

[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

Fznamznon updated this revision to Diff 271133. Fznamznon marked an inline comment as done. Fznamznon added a comment. Generalized diagnostic between SYCL and OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81641/new/ https://reviews.llvm.org