[PATCH] D81552: [ASTMatchers] Added hasDirectBase Matcher

2020-07-07 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb0d3ea171bd5: [ASTMatchers] Added hasDirectBase Matcher (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D81552?vs=275991&id=276073#toc Repository: rG LLVM Github Monorepo C

[PATCH] D81552: [ASTMatchers] Added hasDirectBase Matcher

2020-07-07 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a whitespace nit. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2895 + BaseSpecMatcher) { + + return Node.hasDefinition() &&

[PATCH] D81552: [ASTMatchers] Added hasDirectBase Matcher

2020-07-07 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. I've removed the hasClass changes as they dont entirely belong in here and weren't well received. Now with just the hasDirectBase this should be in a good state. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81552/new/ h