[PATCH] D81522: Fix variables used only in asserts.

2020-06-15 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Thanks for the fix! Totally within the realm of post-commit review so far as I can see. The paired assertions could maybe be rewritten as: "assert(MRMgr.getVarRegion(P, SFC) ->getKind()== (SFC->inTopFrame() ? NonParamVarRegionKind : ParamVarRegionKind));" though it's n

[PATCH] D81522: Fix variables used only in asserts.

2020-06-09 Thread Sterling Augustine via Phabricator via cfe-commits
saugustine created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. saugustine edited the summary of this revision. saugustine added a reviewer: baloghadamsoftware. Herald added a subscriber: rnkovacs. Fix variables used only in asserts. For post-commit review

[PATCH] D81522: Fix variables used only in asserts.

2020-06-09 Thread Sterling Augustine via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGccd192204da4: Fix variables used only in asserts. (authored by saugustine). Repository: rG LLVM Github Monorepo CHANGE