[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

hliao added a comment. In D81427#2085739 , @thakis wrote: > This doesn't pass tests: http://45.33.8.238/linux/19977/step_7.txt > > Please take a look, and please revert for now if fixing takes a while. Fixed in https://github.com/llvm/llvm-project/commi

[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

hliao added a comment. In D81427#2085739 , @thakis wrote: > This doesn't pass tests: http://45.33.8.238/linux/19977/step_7.txt > > Please take a look, and please revert for now if fixing takes a while. Thanks. I am building with PowerPC enabled to reprod

[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b6821a5843b: [hip] Fix device-only relocatable code compilation. (authored by hliao). Changed prior to commit: https://reviews.llvm.org/D81427?vs=269555&id=269928#toc Repository: rG LLVM Github Mono

[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

thakis added a comment. This doesn't pass tests: http://45.33.8.238/linux/19977/step_7.txt Please take a look, and please revert for now if fixing takes a while. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81427/new/ https://reviews.llvm.org/D81

[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81427/new/ https://reviews.llvm.org/D81427 ___

[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

hliao updated this revision to Diff 269555. hliao added a comment. Revise following reviewer's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81427/new/ https://reviews.llvm.org/D81427 Files: clang/lib/Driver/Driver.cpp clang/test/Driv

[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

tra added a comment. LGTM in general, but I'll let Sam stamp it. Comment at: clang/lib/Driver/Driver.cpp:4594-4599 +if (!AtTopLevel && JA.getType() == types::TY_LLVM_BC && +(C.getArgs().hasArg(options::OPT_emit_llvm) || + (JA.getOffloadingDeviceKind() == Act

[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

hliao created this revision. hliao added reviewers: yaxunl, tra. Herald added a project: clang. Herald added a subscriber: cfe-commits. - In HIP, just as the regular device-only compilation, the device-only relocatable code compilation should not involve offload bundle. - In addition, that device