[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dblaikie added a comment. In D81347#2080217 , @aprantl wrote: > I was going to ask why make this change, but looking at the patch, it's > pretty obvious :-) Might be worth writing it down for everyone else - isn't exactly obvious to me (though not a par

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

This revision was automatically updated to reflect the committed changes. Closed by commit rGe87e55edbc79: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81347/new/

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang updated this revision to Diff 269845. dang added a comment. Missed a case where an ASTFileSignature was created using an explicit `std::copy` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81347/new/ https://reviews.llvm.org/D81347 Files: c

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang added inline comments. Comment at: clang/include/clang/Basic/Module.h:29 #include "llvm/ADT/iterator_range.h" +#include #include aprantl wrote: > Can you move the code that depends on algorithm into a .cpp file? That code is the call to `std::copy` in th

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang updated this revision to Diff 269473. dang marked 3 inline comments as done. dang added a comment. Fix bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81347/new/ https://reviews.llvm.org/D81347 Files: clang/include/clang/Basic/Module.h

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang updated this revision to Diff 269468. dang marked an inline comment as done. dang added a comment. Address @aprantl's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81347/new/ https://reviews.llvm.org/D81347 Files: clang/include/cla

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM once @aprantl is happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81347/new/ https://reviews.llvm.org/D81347 ___

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

aprantl added a comment. I was going to ask why make this change, but looking at the patch, it's pretty obvious :-) Comment at: clang/include/clang/Basic/Module.h:29 #include "llvm/ADT/iterator_range.h" +#include #include Can you move the code that depends

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/Basic/Module.h:70 + + static ASTFileSignature createDISentinel() { +ASTFileSignature Sentinel; I couldn't find anywhere in the code base that checks the bit-pa

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang created this revision. dang added reviewers: aprantl, dexonsmith, Bigcheese. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/Basic/Module.h:70 +