This revision was automatically updated to reflect the committed changes.
Closed by commit rG72d20b9604f6: [LLVM] Change isa<> to a variadic
function template (authored by jurahul, committed by mehdi_amini).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
jurahul added a comment.
Yes, I'd appreciate if someone can land this change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81045/new/
https://reviews.llvm.org/D81045
___
cfe-commits mailing list
cfe-c
mehdi_amini added a comment.
Do you need someone to land this for you?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81045/new/
https://reviews.llvm.org/D81045
___
cfe-commits mailing list
cfe-commits@
jurahul updated this revision to Diff 270015.
jurahul edited the summary of this revision.
jurahul added a comment.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81045/new/
https://reviews.llvm.org/D81045
Files:
clang/inc
rriddle accepted this revision.
rriddle marked an inline comment as done.
rriddle added a comment.
This revision is now accepted and ready to land.
I have run into the desire to have this on many occasions, so LGTM for me.
Comment at: clang/include/clang/AST/DeclBase.h:521
jurahul updated this revision to Diff 269870.
jurahul added a comment.
Split isa<> changes into its own change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81045/new/
https://reviews.llvm.org/D81045
Files:
clang/include/clang/AST/DeclBase.h
l
