[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-06-15 Thread Balázs Kéri via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGefa8b6e884aa: [Analyzer][StreamChecker] Add check for pointer escape. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80699/new/ https

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-06-14 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. > @NoQ @baloghadamsoftware Escapes are more within your realm of expertise. > Anything to add? This looks like a fairly standard approach to take, no objections. Comment at: clan

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-06-12 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:439-441 + // Do not handle untracked stream. It is probably escaped. + if (!State->get(StreamSym)) +return; balazske wrote: > Szelethus wrote: > > How

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-06-05 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a reviewer: NoQ. Szelethus added a subscriber: NoQ. Szelethus added a comment. @NoQ @baloghadamsoftware Escapes are more within your realm of expertise. Anything to add? From my end, this looks okay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-06-05 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 268701. balazske added a comment. Removed bad empty line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80699/new/ https://reviews.llvm.org/D80699 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-06-05 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 268696. balazske added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80699/new/ https://reviews.llvm.org/D80699 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp clang/test/An

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-06-04 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 268459. balazske added a comment. Using range-based for loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80699/new/ https://reviews.llvm.org/D80699 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-06-04 Thread Balázs Kéri via Phabricator via cfe-commits
balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:439-441 + // Do not handle untracked stream. It is probably escaped. + if (!State->get(StreamSym)) +return; Szelethus

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-06-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:439-441 + // Do not handle untracked stream. It is probably escaped. + if (!State->get(StreamSym)) +return; How does this interact with D78280? ==

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-05-28 Thread Balázs Kéri via Phabricator via cfe-commits
balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. After an escape