[PATCH] D80606: [libTooling][NFC] Demo bug introduced in D72534.

2020-05-27 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. In D80606#2057136 , @steveire wrote: > It might make sense for now (in order to unblock you) to make the > `Transformer` library explicitly require the `AsIs` mode. I am not so > familiar with the transformer library, but I think

[PATCH] D80606: [libTooling][NFC] Demo bug introduced in D72534.

2020-05-27 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. It might make sense for now (in order to unblock you) to make the `Transformer` library explicitly require the `AsIs` mode. I am not so familiar with the transformer library, but I think you can do that by adding `traverse(AsIs, ...)` in `Transformer::registerMatchers`

[PATCH] D80606: [libTooling][NFC] Demo bug introduced in D72534.

2020-05-26 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel created this revision. ymandel added reviewers: hokein, gribozavr. Herald added a project: clang. DO NOT PUSH. This patch includes two new tests that demo a bug introduced into Transformer by https://reviews.llvm.org/D72534. This patch is intended only as a demonstration of the problem.