njames93 added a comment.
It would take more complex matching and diagnostics logic, but it would be so
much nicer if the diagnostics were grouped. So instead of having a diagnostic
about class `X` defining a copy construct and another about it defining a copy
assignment operator, It could just
jbcoe added a comment.
Perhaps associated is https://github.com/isocpp/CppCoreGuidelines/issues/870
which was closed but never (in my mind) resolved.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80490/new/
https://reviews.llvm.org/D80490
_
jbcoe added a comment.
https://reviews.llvm.org/D16376 was written by me, I'm afraid I don't recall
why I abandoned it and was surprised to see that it had not been submitted.
I don't feel comfortable approving work based on my own but this patch looks
great to me.
Repository:
rG LLVM Githu
