[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

This revision was automatically updated to reflect the committed changes. Closed by commit rG95d7ccb70b9c: [PCH] Support writing BuiltinBitCastExprs to PCHs (authored by hyd-dev, committed by erik.pilkington). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

hyd-dev updated this revision to Diff 269765. hyd-dev marked an inline comment as done. hyd-dev added a comment. Address the comment: remove `PathSize` from `BuiltinBitCastExpr`'s constructor and `assert()` it `== 0`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80360/new/ https://rev

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

hyd-dev added a comment. If this is OK, please commit it with `--author "hyd-dev "`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80360/new/ https://reviews.llvm.org/D80360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM (after a minor comment), thank you for fixing this! Comment at: clang/lib/Serialization/ASTReaderStmt.cpp:3598 + S = new (Context) BuiltinBitCastE

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

hyd-dev added a comment. **Ping?** CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80360/new/ https://reviews.llvm.org/D80360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

hyd-dev updated this revision to Diff 265436. hyd-dev added a comment. Format the test `builtin-bit-cast.cpp`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80360/new/ https://reviews.llvm.org/D80360 Files: clang/include/clang/AST/ExprCXX.h clang/include/clang/Serialization/ASTBitC

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

hyd-dev created this revision. hyd-dev added reviewers: erik.pilkington, rsmith. hyd-dev added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. hyd-dev edited the summary of this revision. hyd-dev edited the summary of this revision. D62825 add