[PATCH] D80200: [AST][RecoveryExpr] Fix an assertion crash on openMP.

2020-05-19 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80200/new/ https://reviews.llvm.org/D80200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D80200: [AST][RecoveryExpr] Fix an assertion crash on openMP.

2020-05-19 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG23954318f49f: [AST][RecoveryExpr] Fix an assertion crash on openMP. (authored by hokein). Herald added a subscriber: sstefan1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D80200: [AST][RecoveryExpr] Fix an assertion crash on openMP.

2020-05-19 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80200/new/ https://reviews.llvm.org/D80200 ___

[PATCH] D80200: [AST][RecoveryExpr] Fix an assertion crash on openMP.

2020-05-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a subscriber: ABataev. sammccall added a comment. This seems vaguely reasonable to me, but I don't really know what an OpenMP capture is. @ABataev, @jdoerfert : Any thoughts or concerns here? Some context: an expression that contains errors can exist after certain types of sema/

[PATCH] D80200: [AST][RecoveryExpr] Fix an assertion crash on openMP.

2020-05-19 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. With recovery expr, it is possible that we have a value-dependent expr within non-dependent context. Repository: rG L