This revision was automatically updated to reflect the committed changes.
sammccall marked 2 inline comments as done.
Closed by commit rGd19265b31e65: [clangd] Avoid wasteful data structures in
RefSlab::Builder (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D79950?vs
sammccall marked 4 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/index/Ref.cpp:11
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/Support/Allocator.h"
+#include "llvm/Support/StringSaver.h"
kbobyrev wrote:
> This
kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of nits.
Thank you for the patch, this is a good idea!
Comment at: clang-tools-extra/clangd/index/Ref.cpp:11
+#include "llvm/ADT/STLExtras.h"
+#includ
sammccall created this revision.
sammccall added a reviewer: kbobyrev.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgrang,
jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
This is worth another 10% or so on InedxBenchmark.DexBuild.
Repository:
rG LLVM
