This revision was automatically updated to reflect the committed changes.
Closed by commit rG735ab46cb414: [clangd] Don't create as much garbage
while building Dex index. (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79918/ne
kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for the patch!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79918/new/
https://reviews.llvm.org/D79918
_
sammccall updated this revision to Diff 263967.
sammccall added a comment.
Use a faster hash function, which seems to be worth something in the
neighbourhood of 4%.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79918/new/
https://reviews.llvm.org/
sammccall updated this revision to Diff 263961.
sammccall added a comment.
Address comments, add more docs.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79918/new/
https://reviews.llvm.org/D79918
Files:
clang-tools-extra/clangd/benchmarks/Index
kbobyrev added a comment.
Wow, nice work, thank you!
Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:51
+public:
+ // Returns the tokens which are given symbol's characteristics. Currently,
the
+ // generated tokens only contain fuzzy matching trigrams and symbol's sc
sammccall created this revision.
sammccall added a reviewer: kbobyrev.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgrang,
jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
The Token objects are relatively expensive and we were spending a lot of
CPU creatin
