[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

2020-07-14 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi updated this revision to Diff 278064. plotfi added a comment. Update for harbormaster. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79730/new/ https://reviews.llvm.org/D79730 Files: clang/lib/Frontend/CompilerInvocation.cpp Index: clan

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

2020-07-09 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Either way, I think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79730/new/ https://reviews.llvm.org/D79730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

2020-07-09 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi added a subscriber: dexonsmith. plotfi added a comment. In D79730#2030530 , @rjmccall wrote: > I think it makes sense; if nothing else, we're trying to upstream all that > work. @rjmccall Should I still try to land this or should this stuff get p

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

2020-05-11 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. I think it makes sense; if nothing else, we're trying to upstream all that work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79730/new/ https://reviews.llvm.org/D79730 ___ c

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

2020-05-11 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi added a comment. In D79730#2030037 , @rjmccall wrote: > I don't think the reversion is necessary; it's being fixed to remove the > dependency. This is a good change, though. Should I still try to land this diff so that it matches the behavior on

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

2020-05-11 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. I don't think the reversion is necessary; it's being fixed to remove the dependency. This is a good change, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79730/new/ https://reviews.llvm.org/D79730

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

2020-05-11 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi created this revision. plotfi added reviewers: rjmccall, ab. Herald added a project: clang. Herald added a subscriber: cfe-commits. After speaking with @ab and @rjmccall on https://reviews.llvm.org/D72841#2027740 and https://github.com/apple/llvm-project/pull/1202. it sounds like code-ge