[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

2020-05-07 Thread Arthur Eubanks via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG48451ee6a7ee: [MSan] Pass MSan command line options under new pass manager (authored by aeubanks). Repository: rG LLVM

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

2020-05-06 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 262426. aeubanks added a comment. Revert back to initial patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79445/new/ https://reviews.llvm.org/D79445 Files: clang/lib/CodeGen/BackendUtil.cpp Index: clan

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

2020-05-06 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. In D79445#2021502 , @aeubanks wrote: > In D79445#2021311 , @leonardchan > wrote: > > > In `addSanitizersAtO0`, could you make something similar to the `ASanPass` > > lambda for the MSa

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

2020-05-05 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka requested changes to this revision. vitalybuka added reviewers: eugenis, glider. vitalybuka added a comment. This revision now requires changes to proceed. In D79445#2021502 , @aeubanks wrote: > In D79445#2021311

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

2020-05-05 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. In D79445#2021311 , @leonardchan wrote: > In `addSanitizersAtO0`, could you make something similar to the `ASanPass` > lambda for the MSan passes and also apply it when adding kernel MSan? It ends up calling an extra `MPM.addPa

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

2020-05-05 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 262248. aeubanks added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79445/new/ https://reviews.llvm.org/D79445 Files: clang/lib/CodeGen/BackendUtil.cpp Index: clang/lib

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

2020-05-05 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. In `addSanitizersAtO0`, could you make something similar to the `ASanPass` lambda for the MSan passes and also apply it when adding kernel MSan? Repository: rG LLVM Github Monorep

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

2020-05-05 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks created this revision. aeubanks added reviewers: nemanjai, vitalybuka, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Properly forward TrackOrigins and Recover user options to the MSan pass under the new pass manager. This makes the number of check-ms