This revision was automatically updated to reflect the committed changes.
Closed by commit rG3483cdc8344d: [Sema] Silence warnings when targeting x86
with VS2019 16.5.4 (authored by aganea).
Changed prior to commit:
https://reviews.llvm.org/D79337?vs=261848&id=262356#toc
Repository:
rG LLVM
aganea added a comment.
Will do, thank you for your time!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79337/new/
https://reviews.llvm.org/D79337
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks, this lgtm. If you could split this up into two commits before landing
it, I'd appreciate it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D793
aganea created this revision.
aganea added reviewers: bkramer, john.brawn, vsk.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya.
Herald added projects: clang, LLVM.
When using Visual Studio 2019 16.5.4, and targetting 32-bit, before this patch
we were seeing:
[1378/3007] Buildin