[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

2020-05-19 Thread MyDeveloperDay via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG807ab2cd0db3: [clang-format] [PR42164] Add Option to Break before While (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D79325?vs=264235&id=265153#toc Repository: rG L

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

2020-05-18 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79325/new/ https://reviews.llvm.org/D79325 ___ cfe-commits mailing list cfe

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

2020-05-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 264235. MyDeveloperDay added a comment. Use BeforeWhile and not IndentBraces to wrap the line Update the release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79325/new/ https://reviews.llvm.org/D79325 Files: clang/docs/ClangFormatSt

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

2020-05-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay planned changes to this revision. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. let me try that.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79325/new/ https://reviews.llvm.org/D79325

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

2020-05-12 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2170 parseBlock(/*MustBeDeclaration=*/false); -if (Style.BraceWrapping.IndentBraces) +if (Style.BraceWrapping.IndentBraces || Style.BraceWrapping.BeforeWhile) addUnwrappedLine

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

2020-05-07 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2170 parseBlock(/*MustBeDeclaration=*/false); -if (Style.BraceWrapping.IndentBraces) +if (Style.BraceWrapping.IndentBraces || S

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

2020-05-06 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir marked an inline comment as done. krasimir added inline comments. Comment at: clang/lib/Format/Format.cpp:691 +/*SplitEmptyRecord=*/true, +/*SplitEmptyNamespace=*/true}; switch (Style.BreakBeforeBraces) { ---

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

2020-05-04 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, mitchell-stellar, sammccall. MyDeveloperDay added projects: clang, clang-format. Its currently not possible to recreate the GNU style using the `BreakBeforeBraces: Custom` style due to a lack of missing `BeforeWhile`