This revision was automatically updated to reflect the committed changes.
Closed by commit rGd870016bfce8: [clangd] Get rid of Inclusion::R (authored by
kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79315/new/
https://reviews.llvm.org/D79
kadircet marked 4 inline comments as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/XRefs.cpp:610
+auto FileRange =
+syntax::FileRange(SM, FileTok->location(), Inc.Written.length())
+.toCharRange(SM);
sammccall
kadircet updated this revision to Diff 261845.
kadircet marked an inline comment as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79315/new/
https://reviews.llvm.org/D79315
Files:
clang-tools-ex
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/Headers.cpp:45
Inc.HashOffset = SM.getFileOffset(HashLoc);
+ // Line numbers are only computed once per SM, it is c
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
This is only used by documentlink and go-to-definition. We are pushing
range detection logic from Inclu
