[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

2020-05-07 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8026394d3cc7: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79186/new

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

2020-05-07 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D79186#2023322 , @jdoerfert wrote: > LGTM. > > In D79186#2016893 , @ABataev wrote: > > > In D79186#2016737 , @jdoerfert > > wrote: > > > > > In D

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

2020-05-06 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. In D79186#2016893 , @ABataev wrote: > In D79186#2016737 , @jdoerfert wrote: > > > In D79186#201368

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

2020-05-03 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D79186#2016737 , @jdoerfert wrote: > In D79186#2013689 , @ABataev wrote: > > > In D79186#2013603 , @jdoerfert > > wrote: > > > > > What would you

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

2020-05-03 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D79186#2013689 , @ABataev wrote: > In D79186#2013603 , @jdoerfert wrote: > > > What would you think about moving the allocator definitions to OMPKinds.def > > instead of listing them e

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

2020-05-01 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 261513. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79186/new/ https://reviews.llvm.org/D79186 Files: clang/include/clang/Basic/Attr.td clang/lib/CodeGen/CGOpenMPRuntime.c

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

2020-04-30 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D79186#2013603 , @jdoerfert wrote: > What would you think about moving the allocator definitions to OMPKinds.def > instead of listing them explicitly? As far as I can tell we really only > distinguish between predefined and us

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

2020-04-30 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Herald added a reviewer: aaron.ballman. What would you think about moving the allocator definitions to OMPKinds.def instead of listing them explicitly? As far as I can tell we really only distinguish between predefined and user allocators, right? Repository: rG LLV

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

2020-04-30 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl, jholewinski. Herald added a project: clang. omp.h header file defines omp_null_allocator as a predefined allocator, need to consider it also as a predefined allocator. Repository: rG