[PATCH] D78843: [clangd] Remove unused bits after 67b2dbd5a33583. NFC

2020-05-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall abandoned this revision. sammccall added a comment. Obsoleted by D79313 (Sorry for ignoring this!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78843/new/ https://reviews.llvm.org/D78843 _

[PATCH] D78843: [clangd] Remove unused bits after 67b2dbd5a33583. NFC

2020-04-26 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:12 #include "index/remote/marshalling/Marshalling.h" #include "llvm/ADT/Optional.h" #include "llvm/ADT/StringRef.h" This can also be removed.

[PATCH] D78843: [clangd] Remove unused bits after 67b2dbd5a33583. NFC

2020-04-24 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Features.inc.in:2 #define CLANGD_BUILD_XPC @CLANGD_BUILD_XPC@ -#define CLANGD_ENABLE_REMOTE @CLANGD_ENABLE_REMOTE@ I don't know how much code will have with `ifdefs` in the Clangd itself, but I

[PATCH] D78843: [clangd] Remove unused bits after 67b2dbd5a33583. NFC

2020-04-24 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. I think these are all safe to remove, but this doesn't build for me right now (https