[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d6d48add8a8: [clangd] Reland 'Handle PresumedLocations in IncludeCollector' (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78740/new/

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet updated this revision to Diff 262374. kadircet added a comment. - use basename in tests as having unescaped backslashes breaks windows build bots. going to address that separetely in line directive generation logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f7917c269d6: [clangd] Handle PresumedLocations in IncludeCollector (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78740/new/ https:/

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet updated this revision to Diff 262324. kadircet added a comment. - Try to fix windows builds Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78740/new/ https://reviews.llvm.org/D78740 Files: clang-tools-extra/clangd/Headers.cpp clang-too

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:39 SrcMgr::CharacteristicKind FileKind) override { -if (isInsideMainFile(HashLoc, SM)) { +auto AddMainFileInc = [&](SourceLocation HashLoc) { Out->MainFileIn

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet updated this revision to Diff 262057. kadircet marked 13 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78740/new/ https://reviews.llvm.org/D78740 Files: clang-tools-e

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, Just readability stuff. Comment at: clang-tools-extra/clangd/Headers.cpp:39 SrcMgr::CharacteristicKind FileKind) override { -if (isIn

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet marked 5 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:44 +PreLoc.getColumn()); + PreLoc = SM.getPresumedLoc(FilenameRange.getBegin()); + auto FileNameBe

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet updated this revision to Diff 261765. kadircet marked an inline comment as done. kadircet added a comment. - Perform line mapping only for includes found through built-in file. - Drop filename range mapping. - Make use of FileChanged events to track being in built-in file. Repository:

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:40 + auto PreLoc = SM.getPresumedLoc(HashLoc); + if (auto FE = SM.getFileManager().getFile(PreLoc.getFilename())) { +if (SM.getFileEntryForID(SM.getMainFileID()) == *FE) { -

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:39 +if (!isInsideMainFile(HashLoc, SM)) { + auto PreLoc = SM.getPresumedLoc(HashLoc); + if (auto FE = SM.getFileManager().getFile(PreLoc.getFilename())) { Is it possib

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This will enable extraction of correct line locations in preamble patch for includes. Repository: r