[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

This revision was automatically updated to reflect the committed changes. Closed by commit rGa88025672f89: [analyzer] Consider array subscripts to be interesting lvalues. (authored by vsavchenko, committed by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/test/Analysis/CheckThatArraySubsciptNodeIsNotCollected.cpp:18-19 +// time to collect redundant nodes. This GC-like mechanism kicks in only when +// the exploded graph is large enough

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

NoQ accepted this revision. NoQ added a comment. Yup. Yet another epic bug! Comment at: clang/test/Analysis/CheckThatArraySubsciptNodeIsNotCollected.cpp:18-19 +// time to collect redundant nodes. This GC-like mechanism kicks in only when +// the exploded graph is large enough

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Everything's clear! Nice detective work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78638/new/ https://reviews.llvm.org/D78638 _

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

vsavchenko added a comment. In D78638#1997576 , @Szelethus wrote: > How come rGe20b388e2f923bfc98f63a13fea9fc19aeaec425 > doesn't > solve this? Or, rather, how come it even worked if t

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

Szelethus added a comment. How come rGe20b388e2f923bfc98f63a13fea9fc19aeaec425 doesn't solve this? Or, rather, how come it even worked if this patch is needed? Is the index being a global variable the issue? The change looks

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

vsavchenko updated this revision to Diff 259341. vsavchenko added a comment. Add more clarity on what we test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78638/new/ https://reviews.llvm.org/D78638 Files: clang/lib/StaticAnalyzer/Core/ExplodedG

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/test/Analysis/PR53280338.cpp:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-output=text -verify %s + martong wrote: > AFAIK rdar is not accessible ou

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

martong added inline comments. Comment at: clang/test/Analysis/PR53280338.cpp:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-output=text -verify %s + AFAIK rdar is not accessible outside Apple. So, for the rest of the open source developers any

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Static analyzer