This revision was automatically updated to reflect the committed changes.
Closed by commit rGee12edcb7642: [Preamble] Allow recursive inclusion of
header-guarded mainfile. (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78366/n
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang/lib/Lex/PPDirectives.cpp:2070
+ diag::err_pp_including_mainfile_in_preamble);
+return {ImportAction::None};
+ }
-
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clang/lib/Lex/PPDirectives.cpp:2070
+ diag::err_pp_including_mainfile_in_preamble);
+return {ImportAction::None};
+ }
kadircet wrote:
> Instead of returning here
kadircet added inline comments.
Comment at: clang/lib/Lex/PPDirectives.cpp:2070
+ diag::err_pp_including_mainfile_in_preamble);
+return {ImportAction::None};
+ }
Instead of returning here I think we should set the Action to `Skip`. So that
relevant
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous,
ilya-biryukov.
Herald added a project: clang.
This is guaranteed to be a no-op without the preamble, so should be a
no-op with it too.
Partially fixes https
