Re: [PATCH] D78192: Support compiler extensions as a normal component

Weird. I already tried the patch under Windows/msvc and had no such problem. Michael Am Fr., 24. Apr. 2020 um 04:15 Uhr schrieb Russell Gallop : > > Hi Serge, > > It looks like this is failing to build on Windows bots (e.g. > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windo

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille added a comment. The patch landed without much errors, only added the patchset e307eeba0137700e75893089cf0de03383d851ca Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

Re: [PATCH] D78192: Support compiler extensions as a normal component

Thanks! On Fri, 24 Apr 2020 at 10:51, Serge Guelton wrote: > On Fri, Apr 24, 2020 at 10:15:15AM +0100, Russell Gallop wrote: > > Hi Serge, > > > > It looks like this is failing to build on Windows bots (e.g. [1]http:// > > > lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-

Re: [PATCH] D78192: Support compiler extensions as a normal component

On Fri, Apr 24, 2020 at 10:15:15AM +0100, Russell Gallop wrote: > Hi Serge, > > It looks like this is failing to build on Windows bots (e.g. [1]http:// > lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/ > builds/32003). Error below. > > Please could you take a look? e

Re: [PATCH] D78192: Support compiler extensions as a normal component

On Fri, Apr 24, 2020 at 10:15:15AM +0100, Russell Gallop wrote: > Hi Serge, > > It looks like this is failing to build on Windows bots (e.g. [1]http:// > lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/ > builds/32003). Error below. > > Please could you take a look? S

Re: [PATCH] D78192: Support compiler extensions as a normal component

Hi Serge, It looks like this is failing to build on Windows bots (e.g. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/32003). Error below. Please could you take a look? Thanks Russ FAILED: tools/llvm-config/CMakeFiles/llvm-config.dir/llvm-config.cpp.ob

[PATCH] D78192: Support compiler extensions as a normal component

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f766e382b77: Update compiler extension integration into the build system (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D78192?vs=259495&id=259827#toc Repository:

[PATCH] D78192: Support compiler extensions as a normal component

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM. As with every change to the build system, please look out broken configurations after committing. You will have noticed already that there is a lot of variety in how others buil

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille updated this revision to Diff 259495. serge-sans-paille added a comment. Fix dependency order for extension libraries, as spotted by @Meinersbur CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78192/new/ https://reviews.llvm.org/D78192 Files: clang/lib/CodeGen/CMakeLi

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille added a comment. In D78192#1997698 , @Meinersbur wrote: > Is this ready to try out? It is! > > > In D78192#1996859 , > @serge-sans-paille wrote: > >> Note that this should solve in an elegan

[PATCH] D78192: Support compiler extensions as a normal component

Meinersbur added a comment. I looks to work fine under my Windows and Linux configuration. One Point though: llvm-config --libs Extensions returns [...] -lPollyPPCG -lPollyISL -lPolly I think `-lPolly` must be first to work with bfd.ld order semantics. See https://stackoverflow.com/questi

[PATCH] D78192: Support compiler extensions as a normal component

Meinersbur added a comment. Is this ready to try out? In D78192#1996859 , @serge-sans-paille wrote: > Note that this should solve in an elegant (?) way the multiple link errors > found when linking clang with LLVM_DYLIB. Aren't these fixed already?

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille added a comment. Note that this should solve in an elegant (?) way the multiple link errors found when linking clang with LLVM_DYLIB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78192/new/ https://reviews.llvm.org/D78192 ___

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille added a comment. @Meinersbur with the latest updat, it should also be compatible with https://github.com/intel/opencl-clang/blob/83837744ef076c1285ed2ee9349febc2208d3252/CMakeLists.txt#L266 as all contains the `Extensions` component. Repository: rG LLVM Github Monorepo CHA

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille updated this revision to Diff 259284. serge-sans-paille added a comment. Herald added subscribers: cfe-commits, dang, dexonsmith, steven_wu, hiraditya. Herald added a project: clang. Instead of linking all compiler extensions to the different possible tagets (clang, opt lto etc)