[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-22 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 293537. tianshilei1992 added a comment. Refined the case `declare_mapper_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-22 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 293505. tianshilei1992 added a comment. Fixed the case `target_parallel_for_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeG

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-22 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 293466. tianshilei1992 added a comment. Fixed the case `target_teams_distribute_simd_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-21 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 293323. tianshilei1992 added a comment. Fixed the case `target_teams_distribute_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/C

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-21 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 293320. tianshilei1992 added a comment. Fixed the case `target_teams_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/CGOp

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-21 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 293254. tianshilei1992 added a comment. Fixed the test case `target_simd_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-21 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 293253. tianshilei1992 added a comment. Fixed the case `target_parallel_for_simd_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-21 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 293195. tianshilei1992 added a comment. Continued to fix the case `target_parallel_for_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clan

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-19 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 292979. tianshilei1992 added a comment. Fixed the case `target_parallel_for_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeG

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-18 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 292835. tianshilei1992 added a comment. Fixed the test case `target_parallel_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/Code

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-17 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 292696. tianshilei1992 added a comment. Fixed the test failure in OMP50 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/CGOpenMPRuntim

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-17 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 292690. tianshilei1992 added a comment. Fixed the test case `target_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/CGOpe

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-16 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 292280. tianshilei1992 added a comment. Fixed an issue that one wildcard is missing in the CHECK line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: cl

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-16 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added a comment. > If I remember correctly, you may yield the thread inside a target region > after enqueuing kernels and transfers. So even with 1 thread, there is chance > to run other tasks without finishing this target. Isn't that possible? I assume you were referring to `tas

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-16 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 292271. tianshilei1992 added a comment. Fixed `declare_mapper_codegen.cpp` with `CK0` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-14 Thread Ye Luo via Phabricator via cfe-commits
ye-luo added a comment. In D78075#2272474 , @tianshilei1992 wrote: > In D78075#2272398 , @ye-luo wrote: > >>> However, OpenMP task has a problem that it must be within >>> to a parallel region; otherwise the task w

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-14 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added a comment. In D78075#2272398 , @ye-luo wrote: >> However, OpenMP task has a problem that it must be within >> to a parallel region; otherwise the task will be executed immediately. As a >> result, if we directly wrap to a regular task,

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-14 Thread Ye Luo via Phabricator via cfe-commits
ye-luo added a comment. > However, OpenMP task has a problem that it must be within > to a parallel region; otherwise the task will be executed immediately. As a > result, if we directly wrap to a regular task, the nowait target outside of a > parallel region is still a synchronous version. The s

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

2020-09-05 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 290104. tianshilei1992 added a comment. Update one test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/te