[PATCH] D78066: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber

2020-04-20 Thread Erik Pilkington via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG85cca945b4c9: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D78066: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber

2020-04-13 Thread Ben D. Jones via Phabricator via cfe-commits
bendjones added a comment. Seems reasonable to me. Thanks @erik.pilkington! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78066/new/ https://reviews.llvm.org/D78066 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D78066: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber

2020-04-13 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, bendjones, arphaman. Herald added subscribers: ributzka, dexonsmith, jkorous. This fixes a common mistake (the 3 should be @3): `NSNumber *n = 3`. This extends an existing check for NSString. Also, this only errs if