This revision was automatically updated to reflect the committed changes.
Closed by commit rG31db1e0bd1ea: [clangd] Send the correct error code when
cancelling requests. (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D77947?vs=256777&id=257031#toc
Repository:
rG L
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/JSONTransport.cpp:28
+ [&](const CancelledError &C) -> llvm::Error {
+switch (C.Reason) {
+ case static_cast(ErrorCode::ContentModif
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
Thanks for remembering this :D LGTM!
Comment at: clang-tools-extra/clangd/JSONTransport.cpp:28
+ [&](const CancelledError &C) -> llvm::Error {
+switc
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous,
MaskRay, javed.absar, ilya-biryukov.
Herald added a project: clang.
I couldn't quite bring myself to make Cancellation depend on LSP ErrorCode.
Magic nu
