[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

This revision was automatically updated to reflect the committed changes. Closed by commit rG615673f3a10e: [Preamble] Invalidate preamble when missing headers become present. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77942?vs=266868&id=269185#toc Repository:

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Let's build more preambles ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77942/new/ https://reviews.llvm.org/D77942 _

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

sammccall marked 5 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:108 +// (We have some false negatives if PP recovered e.g. -> "foo") +if (File == nullptr) + return; kadircet wrote:

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

sammccall updated this revision to Diff 266868. sammccall marked 2 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77942/new/ https://reviews.llvm.org/D77942 Files: clang-tools-e

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

kadircet added a comment. mostly LG, sorry for not noticing regularfile check(or maybe forgetting a discussion ...) at previous revision Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:108 +// (We have some false negatives if PP recovered e.g. -> "foo") +if (Fi

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

sammccall added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:101 + + // We always receive FileNotFound followed by InclusionDirective. + // We want the former, so we're completely sure the file was missing. kadircet wrote: > is there

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

sammccall updated this revision to Diff 266822. sammccall marked 6 inline comments as done. sammccall added a comment. Finally address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77942/new/ https://reviews.llvm.org/D77942 Files: clang

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

kadircet added a comment. It is unfortunate that we are testing `PrecompiledPreamble` through clangd rather than its own unittest :/ Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:101 + + // We always receive FileNotFound followed by InclusionDirective. + // We want

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

sammccall added a comment. At first I thought this would be easy to test via clang/test/PCH, but the outer layers of PrecompiledPreamble seem to be totally distinct from PCHGenerator etc. This is only used in ASTUnit and clangd. Maybe it's reachable in libclang but I couldn't easily work out how

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, javed.absar. Herald added a project: clang. To avoid excessive extra stat()s, only check the possible locations of headers that weren't found at all (leading