[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

This revision was automatically updated to reflect the committed changes. Closed by commit rG0863e94ebd87: [AArch64] Add NVIDIA Carmel support (authored by tambre, committed by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/ htt

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre added a comment. In D77940#2012092 , @sdesmalen wrote: > LGTM! Please land this for me as I lack commit privileges. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/ https://reviews.llvm.

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Comment at: llvm/unittests/Support/TargetParserTest.cpp:1134 AArch64::ArchKind::INVALID, "sve2")); + EXPECT_TRUE( + test

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. sdesmalen: ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/ https://reviews.llvm.org/D77940 _

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre updated this revision to Diff 259653. tambre marked 4 inline comments as done. tambre added a comment. Remove SVE, add another check to parser test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/ https://reviews.llvm.org/D77940 Fil

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre added a comment. In D77940#1998856 , @sdesmalen wrote: > It seems a NVIDIA Developer Program Membership is needed in order to download > the TRM. I'm not sure if that is just a matter of creating an account, but > without it I can't really verify

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

sdesmalen added a comment. It seems a NVIDIA Developer Program Membership is needed in order to download the TRM. I'm not sure if that is just a matter of creating an account, but without it I can't really verify that the architecture version and the features are correct and complete. ==

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre added a comment. sdesmalen: Could you please take another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/ https://reviews.llvm.org/D77940 ___ cfe-commits mailing list cfe-commits@

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre updated this revision to Diff 258513. tambre added a comment. Add cacheline size per the technical reference manual Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/ https://reviews.llvm.org/D77940 Files: clang/test/Driver/aarch64-

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre updated this revision to Diff 258045. tambre marked 6 inline comments as done. tambre added a comment. Remove SVE, fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/ https://reviews.llvm.org/D77940 Files: clang/test/D

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:607 + FeatureSVE + ]>; + sdesmalen wrote: > Not sure how accurate the link you referenced is, but it doesn't mention S

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:607 + FeatureSVE + ]>; + Not sure how accurate the link you referenced is, but it doesn't mention SVE or Crypto ex

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre updated this revision to Diff 256764. tambre added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/ https://reviews.llvm.org/D77940 Files: clang/test/Driver/aarch64-cpus.c clang/test/Preprocessor/aarch6

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre updated this revision to Diff 256763. tambre added a comment. Remove cacheline size Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/ https://reviews.llvm.org/D77940 Files: clang/test/Driver/aarch64-cpus.c clang/test/Preprocessor

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre created this revision. tambre added reviewers: sdesmalen, paquette. Herald added subscribers: cfe-commits, danielkiss, jfb, hiraditya, kristof.beyls. Herald added a project: clang. tambre updated this revision to Diff 256763. tambre added a comment. tambre edited the summary of this revisio