[PATCH] D77938: [clangd] Extend YAML Serialization

sammccall added a comment. Done, thanks for the contributions! Feel free to apply for commit access at any point if you plan to work more on clangd or other LLVM stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77938/new/ https://reviews.llvm

[PATCH] D77938: [clangd] Extend YAML Serialization

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c68de2d6300: [clangd] Extend YAML Serialization (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77938/new/ https://reviews.llvm.org/

[PATCH] D77938: [clangd] Extend YAML Serialization

mnauw added a comment. I do not have commit access, so it would be helpful that you land this (and the other) ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77938/new/ https://reviews.llvm.org/D77938 ___ cfe-commits mailing list cfe-com

[PATCH] D77938: [clangd] Extend YAML Serialization

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! Do you have commit access, or would you like me to land this and D78038 for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7793

[PATCH] D77938: [clangd] Extend YAML Serialization

mnauw updated this revision to Diff 258292. mnauw added a comment. As suggested, existing (YAML) Serialization test has been extended. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77938/new/ https://reviews.llvm.org/D77938 Files: clang-tools-extra/clangd/index/YAMLSerialization.cpp

[PATCH] D77938: [clangd] Extend YAML Serialization

sammccall added a comment. Thanks for doing this! Comment at: clang-tools-extra/clangd/unittests/YAMLTests.cpp:1 +//===-- YAMLTests.cpp - YAML container unit tests -===// +// Ack, sorry for not mentioning this in the previous review. Th

[PATCH] D77938: [clangd] Extend YAML Serialization

mnauw created this revision. mnauw added a reviewer: sammccall. mnauw added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. mnauw added a comment. This was previously part o

[PATCH] D77938: [clangd] Extend YAML Serialization

mnauw added a comment. This was previously part of D77385 . Rather than a separate file (which seems a bit tricky), the test YAML has simply been included in the unit test itself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie