[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2dec2aa3ad08: [Driver] Default to libc++ on FreeBSD (authored by jbeich, committed by emaste). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

emaste added inline comments. Comment at: clang/test/Driver/freebsd.cpp:13-14 +// RUN: | FileCheck --check-prefix=CHECK-PG-DEFAULT %s // RUN: %clangxx %s -### -pg -o %t.o -target amd64-unknown-freebsd14.0 -stdlib=platform 2>&1 \ // RUN: | FileCheck --check-prefix=CHECK-PG-

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

emaste updated this revision to Diff 388931. emaste added a comment. rebase tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 Files: clang/lib/Driver/ToolChains/FreeBSD.cpp clang/test/Driver/freebsd.cpp Index: clang/test/Driver/freebsd

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

myfreeweb added a comment. Herald added a subscriber: pengfei. It's been over a year and no solutions have been merged! The problem just popped up again in Firefox after a pull. With clang 13.0, and the discussion above was before 11.0 release >_< Can someone commit something already?! Reposi

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

dim added a comment. In D6#2187334 , @myfreeweb wrote: > In D6#2187273 , @dim wrote: > >>> +#ifdef __FreeBSD__ >>> + return __FreeBSD_version / 10; >>> +#else >>> + return 10; >>> +#endif >

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

myfreeweb added a comment. In D6#2187273 , @dim wrote: >> +#ifdef __FreeBSD__ >> +return __FreeBSD_version / 10; >> +#else >> +return 10; >> +#endif > > No, that would hardcode something at build time. We need to respect whatever

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

dim added a comment. In D6#1993211 , @arichardson wrote: > I don't like the fact that this only changes one of the users of > `getTriple().getOSMajorVersion()`. Why not, if this is a one-off case, it's perfectly OK to put it in here. Maybe add a com

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

myfreeweb added a comment. ping. can we get *some* solution to this included in llvm 11.0 final release? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 ___ cfe-c

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

arichardson added a comment. I don't like the fact that this only changes one of the users of `getTriple().getOSMajorVersion()`. Could you add a new member function such as void FreeBSD::getMajorVersion() const { unsigned Major = getTriple().getOSMajorVersion(); if (Major == 0)

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. Looks ok to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 _

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

emaste added a comment. In D6#1981271 , @jbeich wrote: > - Limit the scope to `-stdlib` > > In D6#1972543 , @dim wrote: > > > the lowest supported version, which is currently 10 > > > Where is this defined?

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

jbeich updated this revision to Diff 257403. jbeich retitled this revision from "[Driver] Drop support for FreeBSD < 10" to "[Driver] Default to libc++ on FreeBSD". jbeich added a comment. - Limit the scope to `-stdlib` In D6#1972543 , @dim wrote: >