This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG098e40eac524: [clangd] Add index export to dexp (authored by
sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES S
mnauw added a comment.
As suggested, I will provide the YAMLSerialization changes in a separate patch.
Regarding test for that, I was thinking of some running some "simple/mock YAML
data" through some load and save cycle(s). I presume a separate YAML file (in
e.g. test/Inputs) is best for tha
mnauw updated this revision to Diff 256557.
mnauw edited the summary of this revision.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77385/new/
https://reviews.llvm.org/D77385
Files:
clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp
Index: clang-tools-extra/clangd/index/dex/dexp/Dexp.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:322
+ // Make Export command option(s) available on command line.
+ // That allows for convenient (piping/redirecting) a dump non-interactively
+ // without passing through REPL.
kbobyrev added a comment.
> Typical use is to read RIFF data to dump to YAML for inspection of indexed
> data. The YAML (de)serialization has also been extended to aid in this regard.
Just curious: what is the typical usecase for YAML index inspection? Maybe if
there is something missing in Dex
sammccall added a comment.
Thanks, this looks pretty good!
Comment at: clang-tools-extra/clangd/index/YAMLSerialization.cpp:36
namespace {
using RefBundle =
this is independent of adding the dump command - can we split this into a
separate patch?
Partly be
mnauw updated this revision to Diff 255019.
mnauw retitled this revision from "[clangd] Add index inspection helper tool"
to "[clangd] Add index export to dexp".
mnauw edited the summary of this revision.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77385/new/
https://reviews.llvm.org/D
