[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

2020-04-09 Thread Serge Pavlov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc7ff5b38f27f: [FPEnv] Use single enum to represent rounding mode (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D77379?vs=255949&id=256203#toc Repository: rG LLVM Github M

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

2020-04-08 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. I can accept this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77379/new/ https://reviews.llvm.org/D77379 __

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

2020-04-08 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:26 +/// assigned to the rounding modes must agree with the values used by FLT_ROUNDS +/// (C11, 5.2.4.2.2p8). +enum class RoundingMode : int8_t { --

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

2020-04-08 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 255949. sepavloff added a comment. Updated patch - Fixed comment, - Mention "round.tonearestaway" in documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77379/new/ https://reviews.llvm.org/D77379 F

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

2020-04-07 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 255710. sepavloff added a comment. Removed dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77379/new/ https://reviews.llvm.org/D77379 Files: clang/include/clang/Basic/LangOptions.def clang/inclu

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

2020-04-07 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:26 +/// assigned to the rounding modes must agree with the values used by FLT_ROUNDS +/// (C11, 5.2.4.2.2p8). +enum class RoundingMode : int8_t { sepavloff wrote: > rjmccall wr

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

2020-04-07 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:26 +/// assigned to the rounding modes must agree with the values used by FLT_ROUNDS +/// (C11, 5.2.4.2.2p8). +enum class RoundingMode : int8_t { --

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

2020-04-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added a reviewer: scanon. rjmccall added inline comments. Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:26 +/// assigned to the rounding modes must agree with the values used by FLT_ROUNDS +/// (C11, 5.2.4.2.2p8). +enum class RoundingMode : int8_t {

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

2020-04-06 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:26 +/// assigned to the rounding modes must agree with the values used by FLT_ROUNDS +/// (C11, 5.2.4.2.2p8). +enum class RoundingMode : int8_t { --

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

2020-04-06 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 255267. sepavloff added a comment. Updated patch - enhancements of LangOptions.def are moved into separate patch, - fixed some clang-format errors, - added more comments to RoundingMode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

2020-04-03 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:26 +/// assigned to the rounding modes must agree with the values used by FLT_ROUNDS +/// (C11, 5.2.4.2.2p8). +enum class RoundingMode : int8_t { I agree that we should use one

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

2020-04-03 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff created this revision. sepavloff added reviewers: rjmccall, andrew.w.kaylor, arsenm, kpn, cameron.mcinally, uweigand. Herald added subscribers: dexonsmith, hiraditya, wdng. Herald added a project: clang. Now compiler defines 5 sets of constants to represent rounding mode. These are: 1.