This revision was automatically updated to reflect the committed changes.
Closed by commit rG164ed7b1d044: [clangd] Enable some nice clang-tidy checks by
default. (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D77348?vs=254650&id=254789#toc
Repository:
rG LLVM Git
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:695
+auto EmptyDefaults = tidy::ClangTidyOptions::getDefaults();
+EmptyDefaults.Checks.reset(); // So we can tell if checks were ever set.
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:695
+auto EmptyDefaults = tidy::ClangTidyOptions::getDefaults();
+EmptyDefaults.Checks.reset(); // So we
sammccall updated this revision to Diff 254650.
sammccall added a comment.
revert debugging noise
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77348/new/
https://reviews.llvm.org/D77348
Files:
clang-tools-extra/clangd/tool/ClangdMain.cpp
Inde
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous,
MaskRay, ilya-biryukov.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D77348
Files:
clang-tools-e