This revision was automatically updated to reflect the committed changes.
Closed by commit rG37ac1c19bed7: [Analyzer][VLASize] Support multi-dimensional
arrays. (authored by balazske).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77305/new/
https:/
balazske updated this revision to Diff 256307.
balazske marked 3 inline comments as done.
balazske added a comment.
Small renamings and reformatting.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77305/new/
https://reviews.llvm.org/D77305
Files:
martong accepted this revision.
martong added a comment.
LGTM, nice work!
Comment at: clang/lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp:163
+ // Walk over the VLAs for every dimension until a non-VLA is found.
+ // Collect the sizes, put the most inner VLA to `VLALast`.
+
Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
LGTM, thanks! I'm not terribly knowledgable about VLAs, if someone else would
gave a green light it would be even better.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
balazske updated this revision to Diff 255388.
balazske added a comment.
Added comments and test for extent.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77305/new/
https://reviews.llvm.org/D77305
Files:
clang/lib/StaticAnalyzer/Checkers/VLASiz
Szelethus added a comment.
It would be great to see a test about properly setting the arrays extent.
Otherwise LGTM.
Comment at: clang/lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp:61
+ // warned about that already.
+ // FIXME: report bug?
+ if (SizeV.isUnknown())
balazske created this revision.
Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso,
gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet,
baloghadamsoftware, xazax.hun.
Herald added a reviewer: Szelethus.
Herald added a project: clang.
Check the size
