[PATCH] D77115: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections

2020-04-14 Thread Sam Clegg via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3ea1c62cbae2: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections (authored by sbc100). Changed prior to commit: https://reviews.llvm.org/D77115?vs=253941&id=257476#toc Repository: rG LLVM Git

[PATCH] D77115: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections

2020-03-31 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 updated this revision to Diff 253941. sbc100 added a comment. Avoid resuing IsUsedInReloc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77115/new/ https://reviews.llvm.org/D77115 Files: clang/test/Driver/embed-bitcode-wasm.c clang/test/

[PATCH] D77115: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections

2020-03-31 Thread Alex Crichton via Phabricator via cfe-commits
alexcrichton accepted this revision. alexcrichton added a comment. This revision is now accepted and ready to land. At least from my POV looks good :) Thanks for the quick patch! Should this link

[PATCH] D77115: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections

2020-03-31 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 updated this revision to Diff 253935. sbc100 added a comment. strip in linker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77115/new/ https://reviews.llvm.org/D77115 Files: clang/test/Driver/embed-bitcode-wasm.c clang/test/Driver/fembe

[PATCH] D77115: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections

2020-03-31 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 added a comment. In D77115#1952536 , @alexcrichton wrote: > Seems reasonable to me! In my testing though if these existed as custom > sections they'd still make their way to the final binary through LLD, so > could LLD skip over these sectiosn by

[PATCH] D77115: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections

2020-03-31 Thread Alex Crichton via Phabricator via cfe-commits
alexcrichton added a comment. Seems reasonable to me! In my testing though if these existed as custom sections they'd still make their way to the final binary through LLD, so could LLD skip over these sectiosn by default? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D77115: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections

2020-03-30 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 created this revision. Herald added subscribers: cfe-commits, jfb, sunfish, aheejin, hiraditya, jgravelle-google, dschuff. Herald added a project: clang. sbc100 added reviewers: alexcrichton, sunfish. Fixes: https://bugs.llvm.org/show_bug.cgi?id=45362 Repository: rG LLVM Github Monorep