This revision was automatically updated to reflect the committed changes.
sbc100 marked an inline comment as done.
Closed by commit rG0731372ee25c: [clang] Allow -DDEFAULT_SYSROOT to be a
relative path (authored by sbc100).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https:
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76653/new/
https://reviews.llvm.org/D76653
___
sbc100 updated this revision to Diff 252909.
sbc100 added a comment.
feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76653/new/
https://reviews.llvm.org/D76653
Files:
clang/CMakeLists.txt
clang/lib/Driver/Driver.cpp
Index: clang/lib/D
sbc100 marked 3 inline comments as done.
sbc100 added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:143
+ if (llvm::sys::path::is_relative(SysRoot)) {
+// Prepend InstalledDir if SysRoot is relative
phosek wrote:
> Does this return `true` or `fa
phosek added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:143
+ if (llvm::sys::path::is_relative(SysRoot)) {
+// Prepend InstalledDir if SysRoot is relative
Does this return `true` or `false` when sysroot is empty?
Comment at
sbc100 added a comment.
Hmm.. `arc diff` was behaving strangely for me and failed to update this PR as
I expected. Should fixed now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76653/new/
https://reviews.llvm.org/D76653
_
sbc100 updated this revision to Diff 252725.
sbc100 added a comment.
squash
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76653/new/
https://reviews.llvm.org/D76653
Files:
clang/CMakeLists.txt
clang/lib/Driver/Driver.cpp
Index: clang/lib/Dri
sbc100 updated this revision to Diff 252724.
sbc100 added a comment.
feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76653/new/
https://reviews.llvm.org/D76653
Files:
clang/lib/Driver/Driver.cpp
Index: clang/lib/Driver/Driver.cpp
==
phosek added a comment.
Is this patch up to date?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76653/new/
https://reviews.llvm.org/D76653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
phosek added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:140
+ if (llvm::sys::path::is_relative(SysRoot)) {
+SysRoot = GetResourcesPath(ClangExecutable, SysRoot);
+ }
I don't think this is an intended use for `GetResourcesPath` since this is no
sbc100 added a comment.
I have no idea how to write a test for this, but I tested it locally with wasi
SDK.
Hopefully fucia will find this useful too as a generic version of
https://reviews.llvm.org/D42019
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm
sbc100 created this revision.
Herald added subscribers: cfe-commits, sunfish, aheejin, mgorny, dschuff.
Herald added a project: clang.
sbc100 retitled this revision from "Allow -DDEFAULT_SYSROOT to be a relative
path" to "[clang] Allow -DDEFAULT_SYSROOT to be a relative path".
sbc100 added reviewe
12 matches
Mail list logo
