[PATCH] D76504: [clang] Fix crash during template sema checking

This revision was automatically updated to reflect the committed changes. Closed by commit rGd260a10d98df: [clang] Fix crash during template sema checking (authored by gchatelet). Changed prior to commit: https://reviews.llvm.org/D76504?vs=251780&id=251837#toc Repository: rG LLVM Github Mono

[PATCH] D76504: [clang] Fix crash during template sema checking

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/SemaChecking.cpp:1655 +// greater than 0. When `size` is value dependent we cannot evaluate its +// value so we bail<< out. +i

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet updated this revision to Diff 251780. gchatelet added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76504/new/ https://reviews.llvm.org/D76504 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/builtin

[PATCH] D76504: [clang] Fix crash during template sema checking

efriedma added a comment. Please post patches against master, not previous versions of the patch. I think you want to check isValueDependent(); isInstantiationDependent() includes some other stuff that isn't relevant here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet updated this revision to Diff 251671. gchatelet marked an inline comment as done. gchatelet added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76504/new/ https://reviews.llvm.org/D76504 Files: clang/lib/Sem

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1655 +clang::Expr *SizeOp = TheCall->getArg(2); +// If any arg is instantiation dependent we bail out. +if (DstOp->isInstantiationDependent() || courbet wrote: > Are the firs

[PATCH] D76504: [clang] Fix crash during template sema checking

courbet added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1655 +clang::Expr *SizeOp = TheCall->getArg(2); +// If any arg is instantiation dependent we bail out. +if (DstOp->isInstantiationDependent() || Are the first two necessary ? I

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet created this revision. gchatelet added reviewers: efriedma, courbet. Herald added a project: clang. Herald added a subscriber: cfe-commits. gchatelet added a subscriber: abrachet. gchatelet added a comment. Buggy trace here

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet added a comment. Buggy trace here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76504/new/ https://reviews.llvm.org/D76504 __