[PATCH] D76455: [NFC] Refactor handling of Xarch option

2020-03-22 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG78957bab5515: [NFC] Refactor handling of Xarch option (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7645

[PATCH] D76455: [NFC] Refactor handling of Xarch option

2020-03-19 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D76455#1932232 , @tra wrote: > +1 for refactoring, but what's the long term plan. > Long time ago echristo@ and I had a vague idea to change clang's option > parsing to allow something like ` -Xarch_host -Xarch_device > -Xar

[PATCH] D76455: [NFC] Refactor handling of Xarch option

2020-03-19 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. +1 for refactoring, but what's the long term plan. Long time ago echristo@ and I had a vague idea to change clang's option parsing to allow something like ` -Xarch_host -Xarch_device -Xarch= only...>` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76455/new/ http

[PATCH] D76455: [NFC] Refactor handling of Xarch option

2020-03-19 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. Extract common code to a function. To prepare for adding an option for CUDA/HIP host and device only option. https://reviews.llvm.org/D76455 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp clang/lib/