[PATCH] D76396: Allow immediate invocation of constructors

2020-03-19 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D76396#1930773 , @Tyker wrote: > I have already a patch aiming to do the same thing. D74007 > Thanks. Sorry I dropped the ball on that one. =/ Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D76396: Allow immediate invocation of constructors

2020-03-19 Thread Wyatt Childers via Phabricator via cfe-commits
wchilders abandoned this revision. wchilders added a comment. In D76396#1930773 , @Tyker wrote: > I have already a patch aiming to do the same thing. D74007 > Oof, okay, sounds good. I was not aware of this patch, it lo

[PATCH] D76396: Allow immediate invocation of constructors

2020-03-19 Thread Tyker via Phabricator via cfe-commits
Tyker added a comment. thanks for the the patch, but I have already a patch aiming to do the same thing. D74007 > Provide improvements which allow the cached values of ConstantExpr to be used > by both the constant evaluator and code gen this is definitely som

[PATCH] D76396: Allow immediate invocation of constructors

2020-03-18 Thread Wyatt Childers via Phabricator via cfe-commits
wchilders marked an inline comment as done. wchilders added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6466 if (Entity.allowsNRVO()) CurInit = S.BuildCXXConstructExpr(Loc, Step.Type, Step.Function.FoundDecl, -

[PATCH] D76396: Allow immediate invocation of constructors

2020-03-18 Thread Wyatt Childers via Phabricator via cfe-commits
wchilders marked an inline comment as done. wchilders added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6466 if (Entity.allowsNRVO()) CurInit = S.BuildCXXConstructExpr(Loc, Step.Type, Step.Function.FoundDecl, -

[PATCH] D76396: Allow immediate invocation of constructors

2020-03-18 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6466 if (Entity.allowsNRVO()) CurInit = S.BuildCXXConstructExpr(Loc, Step.Type, Step.Function.FoundDecl, It looks like the other callers to

[PATCH] D76396: Allow immediate invocation of constructors

2020-03-18 Thread Wyatt Childers via Phabricator via cfe-commits
wchilders created this revision. wchilders added reviewers: rsmith, Tyker. Herald added a project: clang. Herald added a subscriber: cfe-commits. wchilders retitled this revision from "Allow immediate invocations of constructors" to "Allow immediate invocation of constructors". Hi all, This is a