[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

2020-03-23 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa711a3a46039: [Syntax] Build mapping from AST to syntax tree nodes (authored by hlopko, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

2020-03-23 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 252045. hlopko marked 5 inline comments as done. hlopko added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76355/new/ https://reviews.llvm.org/D76355 Files: clang/include/clang/To

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

2020-03-23 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko added a comment. PTAL. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:173 +private: + // Keys are either Stmt* or Decl*. + llvm::DenseMap Nodes; gribozavr2 wrote: > The comment is not needed anymore. Clang tidy complains when I remove it :/ Repos

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

2020-03-23 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:129 + void SetRole(NodeRole NR); + `setRole()` (in new code). Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:975 + const syntax::Token *Template

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

2020-03-23 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:570 + auto *N = new (allocator()) syntax::SimpleDeclarator; + Builder.foldNode(Builder.getRange(R.getBegin(), R.getEnd()), N, D); + Builder.markChild(N, syntax::NodeRole::SimpleDeclara

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

2020-03-23 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 251993. hlopko marked 6 inline comments as done. hlopko added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76355/new/ https://reviews.llvm.org/D76355 Files: clang/include/clang/To

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

2020-03-23 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:173 +private: + // Keys are either Stmt* or Decl*. + llvm::DenseMap Nodes; The comment is not needed anymore. Comment at: clang/lib/Tooling/Syntax/BuildTree.

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

2020-03-23 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 251968. hlopko added a comment. Reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76355/new/ https://reviews.llvm.org/D76355 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/lib/Tooling/Syntax/Bu

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

2020-03-20 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 251603. hlopko added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76355/new/ https://reviews.llvm.org/D76355 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/lib/Tooli

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

2020-03-18 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hlopko edited the summary of this revision. hlopko added a parent revision: D76346: [Syntax] Build template declaration nodes. Copy of https://reviews.llvm.org/D72446, submitting with Ilya's permi