This revision was automatically updated to reflect the committed changes.
Closed by commit rGcfc002714a20: [AVR] Support aliases in non-zero address
space (authored by aykevl).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76182/new/
https://reviews
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76182/new/
https://reviews.llvm.org/D76182
aykevl updated this revision to Diff 256977.
aykevl added a comment.
- added test
- using `getPointerAddressSpace` instead of a cast
This is now ready for review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76182/new/
https://reviews.llvm.org/D7
rjmccall requested changes to this revision.
rjmccall added a comment.
This revision now requires changes to proceed.
I agree this needs a test case.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4550
// Create the new alias itself, but don't set a name yet.
+ unsigned AS
dylanmckay added a comment.
Nice patch by the way, the code looks fine, if we can get a basic test in here
then it's good to go
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76182/new/
https://reviews.llvm.org/D76182
___
dylanmckay added a comment.
I think we should add a test, it shouldn't be too hard I think.
Look in `clang/tests`, grep for `alias`. Look like it is `extern const int
__mod_usb_device_table __attribute__ ((alias("wacom_usb_ids")));`. If you copy
paste a new test (use `clang/test/CodeGen/alias.c
aykevl created this revision.
aykevl added reviewers: dylanmckay, rsmith, rjmccall.
Herald added subscribers: cfe-commits, Jim.
Herald added a project: clang.
This fixes code like the following on AVR:
void foo(void) {
}
void bar(void) __attribute__((alias("foo")));
Code like this is prese
